× Help Forum English

Name consent

Inizio
Indietro
1
Avanti
Fine

Hedzer
Autore della discussione
Junior Member

Di più

6 Anni 7 Mesi fa - 6 Anni 7 Mesi fa #15687 da Hedzer

Name consent è stato creato da Hedzer

Good work on the latest ICagenda updates.

Situation:
The consent of publishing the name of the participant is already included in our privacy policy, therefore separate permission is not required on our site. I edited the TOS to include our privacy policy, so consent is registered by agreeing to the TOS.

When I select the option "Force name visibility" for "Name Consent" i expect the registration form to no longer ask for permission. However, the checkbox still shows up (but is ignored since all names show up in the list of participants).

Is this expected behavior or a bug?

For now i have hidden the option with css, but there is no way to select the Section title (consent personal data), which is now empty.

So is it possible to hide the name consent option and the entire section (consent personal data)?

Ultima Modifica 6 Anni 7 Mesi fa da Hedzer.

Ringraziano per il messaggio: Lyr!C

Si prega Accedi o Crea un account a partecipare alla conversazione.

Lyr!C
Administrator
Lead Developer

Di più

6 Anni 7 Mesi fa - 6 Anni 7 Mesi fa #15688 da Lyr!C

Risposta da Lyr!C al topic Name consent

Hello,

Thank you for your report!

It's a legimate review!

So, yes, if you've got consent elsewhere, and so you "Force" consent for iCagenda, the checkbox is not needed.

Could you edit the file :

First, add the call to consent option for name by adding this line after "$name_visibility" (line 197) :

<?php $name_visibility      = $this->params->get('participant_name_visibility', ''); ?>
<?php $name_consent         = $this->params->get('participant_name_consent', ''); ?>

Then, replace line 203-204 :

<?php if (($this->params->get('participantList', 0) && ($name_visibility || $gravatar_checkbox != '0'))
					|| $this->params->get('privacy_organiser', 0)
					|| $gravatar_checkbox == '1'): ?>

By this :

<?php if (($this->params->get('participantList', 0) && ($name_visibility || $gravatar_checkbox != '0' || $name_consent != '0'))
					|| $this->params->get('privacy_organiser', 0)
					|| $gravatar_checkbox == '1'): ?>

And it may works in all cases...

If you can test this "patch" ?

Thank you! :cheer:

Best regards,
Cyril

Latest version : iCagenda 3.9.8
We recommend every user to keep iCagenda updated.
Don't forget to have your Joomla!™ up-to-date!

Do you like iCagenda?
I would appreciate if you could take 5 minutes to post a review on JED (Joomla Extensions Directory) .

Ultima Modifica 6 Anni 7 Mesi fa da Lyr!C.

Si prega Accedi o Crea un account a partecipare alla conversazione.

Hedzer
Autore della discussione
Junior Member

Di più

6 Anni 7 Mesi fa #15694 da Hedzer

Risposta da Hedzer al topic Name consent

Could you edit the file :

What file should I edit?

I can test this patch tonight.

Greetings,
Hedzer

Si prega Accedi o Crea un account a partecipare alla conversazione.

Lyr!C
Administrator
Lead Developer

Di più

6 Anni 7 Mesi fa #15695 da Lyr!C

Risposta da Lyr!C al topic Name consent

Sorry i forgot to mention the file to be modified!...

Here it is : components/com_icagenda/views/registration/tmpl/default.php

;-)

Si prega Accedi o Crea un account a partecipare alla conversazione.

Hedzer
Autore della discussione
Junior Member

Di più

6 Anni 7 Mesi fa #15700 da Hedzer

Risposta da Hedzer al topic Name consent

Unfortunately this patch has no effect.

Si prega Accedi o Crea un account a partecipare alla conversazione.

Lyr!C
Administrator
Lead Developer

Di più

6 Anni 7 Mesi fa #15701 da Lyr!C

Risposta da Lyr!C al topic Name consent

Sorry, i think i copy/paste the wrong test file... (from the wrong branch of my dev version...)

The change for second one modification is this :

<?php if (($this->params->get('participantList', 0) && (($name_visibility && $name_consent != '0') || $gravatar_checkbox != '0'))
					|| $this->params->get('privacy_organiser', 0)
					|| $gravatar_checkbox == '1'): ?>

Cyril

Si prega Accedi o Crea un account a partecipare alla conversazione.

Hedzer
Autore della discussione
Junior Member

Di più

6 Anni 7 Mesi fa - 6 Anni 7 Mesi fa #15702 da Hedzer

Risposta da Hedzer al topic Name consent

I tested this patch and it works in part.

If all privacy options (name consent, gravatar & consent to organiser) are disabled this patch works and the entire section is not shown.

If only name consent is enabled, only name consent is shown as expected. (same as before the patch)
However, if one of the other privacy options is enabled (gravatar consent or consent to organizer) it also asks for name consent.

Looking at the php files, I suspect there should be a modification in models\registration.php lines 164-193 to hide the name consent field if the option is set to "force name visibility". I looks like it now only depends on whether a list of participants is shown.

Ultima Modifica 6 Anni 7 Mesi fa da Hedzer.

Si prega Accedi o Crea un account a partecipare alla conversazione.

Lyr!C
Administrator
Lead Developer

Di più

6 Anni 7 Mesi fa #15703 da Lyr!C

Risposta da Lyr!C al topic Name consent

No need to change in models/registration.php, as those lines are jsut there to remove fields from xml files, to prevent validation checking by Joomla framework ;-)

But what is missing is checking in view for name field individually.

Line 212, add condition for name consent like this :

<?php if ($name_visibility && $name_consent != '0') : ?>

It does not depend on list of participants display, but what is missing, and i will check to add for next release, is an 'Auto' option for Name consent as for Gravatar ;-)

Si prega Accedi o Crea un account a partecipare alla conversazione.

Hedzer
Autore della discussione
Junior Member

Di più

6 Anni 7 Mesi fa - 6 Anni 7 Mesi fa #15704 da Hedzer

Risposta da Hedzer al topic Name consent

That's it. I can confirm that with these changes it now works for all combinations of Privacy settings.

/views/registration/tmpl/default.php start line 196

<?php // PRIVACY ?>
<?php $name_visibility      = $this->params->get('participant_name_visibility', ''); ?>
<?php $name_consent         = $this->params->get('participant_name_consent', ''); ?>
<?php $gravatar_consent     = $this->params->get('participant_gravatar_consent', ''); ?>
<?php $gravatar_checkbox    = ($this->params->get('participantDisplay') != '3' || $gravatar_consent == '1')
? $gravatar_consent: '0'; ?>

<?php if (($this->params->get('participantList', 0) && (($name_visibility && $name_consent != '0') || $gravatar_checkbox != '0'))
|| $this->params->get('privacy_organiser', 0)
|| $gravatar_checkbox == '1'): ?>
<legend><?php echo JText::_('COM_ICAGENDA_REGISTRATION_CONSENT_PERSONAL_DATA_LEGEND'); ?></legend>

<fieldset>

<?php // Privacy: Participant name ?>
<?php if ($name_visibility && $name_consent != '0') : ?>
<?php $name_consent = ($name_visibility == 1) ? '_public' : '_users'; ?>
<?php echo $this->form->renderField('consent_name' . $name_consent, 'consent'); ?>
<?php endif; ?>

Thank you!

Ultima Modifica 6 Anni 7 Mesi fa da Hedzer.

Ringraziano per il messaggio: Lyr!C

Si prega Accedi o Crea un account a partecipare alla conversazione.